Restrict allowed headers and parameters from Pre update password and pre update profile actions #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pre update profile actions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restricts the configuration of allowed headers and parameters for Pre Update Password and Pre Update Profile actions, as these features are not supported during action execution. The changes ensure that API consumers cannot attempt to configure unsupported functionality.
- Remove allowed headers and parameters examples from OpenAPI documentation
- Add validation to reject requests containing allowed headers or parameters for these action types
- Include descriptive error messages for unsupported configuration attempts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Actions.yaml | Removes allowedHeaders and allowedParameters examples from Pre Update Password and Pre Update Profile action documentation |
| PreUpdateProfileActionMapper.java | Adds validation to reject allowed headers/parameters configuration with appropriate error handling |
| PreUpdatePasswordActionMapper.java | Adds validation to reject allowed headers/parameters configuration with appropriate error handling |
| ActionMgtEndpointConstants.java | Defines new error messages for unsupported allowed headers and parameters |
...so2/carbon/identity/api/server/action/management/v1/mapper/PreUpdateProfileActionMapper.java
Show resolved
Hide resolved
|
PR builder started |
...o2/carbon/identity/api/server/action/management/v1/mapper/PreUpdatePasswordActionMapper.java
Show resolved
Hide resolved
...o2/carbon/identity/api/server/action/management/v1/mapper/PreUpdatePasswordActionMapper.java
Show resolved
Hide resolved
...so2/carbon/identity/api/server/action/management/v1/mapper/PreUpdateProfileActionMapper.java
Show resolved
Hide resolved
...so2/carbon/identity/api/server/action/management/v1/mapper/PreUpdateProfileActionMapper.java
Show resolved
Hide resolved
AI Agent Log Improvement Checklist
✅ Before merging this pull request:
|
|
PR builder completed |
jenkins-is-staging
approved these changes
Aug 11, 2025
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/16892102230
indeewari
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issue