-
Notifications
You must be signed in to change notification settings - Fork 168
[ bug-fix ] Fix /api/server/v1/configs/schemas/ API not returning custom SCIM schemas #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...n/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceHolder.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
AI Agent Log Improvement Checklist
✅ Before merging this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the issue where the /api/server/v1/configs/schemas/ API endpoint was not returning custom and system SCIM schemas. The solution replaces the XML-based schema loading with dynamic retrieval from the claim management service.
- Replaces XML file parsing with claim management service integration for schema retrieval
- Adds dynamic monitoring and updating of custom schema attributes
- Implements proper schema mapping for core, user, enterprise, system, and custom SCIM schemas
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| SchemaConfigParser.java | Refactored to retrieve schemas from claim management service instead of XML parsing, added dynamic custom schema monitoring |
| ConfigsServiceHolder.java | Added claim metadata management service integration and external claims retrieval method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceHolder.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceHolder.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceUtils.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceUtils.java
Show resolved
Hide resolved
|
PR builder started |
...on/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceUtils.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/wso2/carbon/identity/api/server/configs/common/SchemaConfigParser.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/17033948831
3e807ea to
f174e36
Compare
Purpose
Approach
Related
Endpoint results after fix
GET /api/server/v1/configs/schemasGET /api/server/v1/configs/schemas/{schema_id}