Skip to content

Conversation

@sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Aug 19, 2025

(cherry picked from commit ddc33ed)
(cherry picked from commit 5ba2638)
(cherry picked from commit 5edb030)
Copilot AI review requested due to automatic review settings August 19, 2025 12:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality to delete pending approval tasks when a workflow request is deleted. The change ensures that when a workflow instance is removed, any associated pending approval tasks are also cleaned up to maintain data consistency.

  • Adds integration with workflow engine's ApprovalTaskService
  • Updates the workflow deletion process to include cleanup of pending approval tasks
  • Introduces proper exception handling for workflow engine operations

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pom.xml Adds workflow engine dependency version configuration
WorkflowServiceFactory.java Updates factory to inject ApprovalTaskService into WorkflowService
WorkflowService.java Integrates approval task deletion into workflow instance deletion logic
org.wso2.carbon.identity.rest.api.server.workflow.v1/pom.xml Adds workflow engine dependency
WorkflowServiceHolder.java Provides access to ApprovalTaskService instance
org.wso2.carbon.identity.api.server.workflow.common/pom.xml Adds workflow engine dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sadilchamishka sadilchamishka merged commit 202f87e into wso2:next Aug 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant