Skip to content

Conversation

@sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Aug 22, 2025

Purpose

The duplicated canonical values send to the processing will be filtered.

Related Issues

Related PRs

(cherry picked from commit 1b49eac)
(cherry picked from commit 2716efe)
Copilot AI review requested due to automatic review settings August 22, 2025 07:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds validation to prevent duplicate canonical values when creating local claims. The implementation deduplicates canonical values based on their labels while preserving insertion order.

  • Introduces deduplication logic using stream operations with a LinkedHashMap to maintain order
  • Adds debug logging to track the number of unique canonical values processed
  • Ensures only unique canonical values by label are serialized to JSON

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sadilchamishka sadilchamishka merged commit c16c863 into wso2:next Aug 22, 2025
2 checks passed
@wso2-engineering-bot
Copy link

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants