Skip to content

Conversation

@sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Aug 23, 2025

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/17170729061

@AnuradhaSK AnuradhaSK requested a review from Copilot August 23, 2025 03:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling for claim validation by migrating from ClaimMetadataClientException to a more structured APIError approach with enhanced error messages and descriptions in the API response.

  • Updated error handling methods to use handleClaimManagementClientError instead of direct exception throwing
  • Enhanced error messages for better clarity and user understanding
  • Removed unused input type constant and improved SCIM mapping validation logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ServerClaimManagementService.java Refactored exception handling to use structured API errors and improved validation logic
Constant.java Updated error message descriptions for better clarity and user experience

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/17170729061
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/17170729061

@sadilchamishka sadilchamishka merged commit 4437751 into wso2:master Aug 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants