-
Notifications
You must be signed in to change notification settings - Fork 168
Improve error handling when claim validation #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling when claim validation #973
Conversation
|
PR builder started |
...mmon/src/main/java/org/wso2/carbon/identity/api/server/claim/management/common/Constant.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves error handling for claim validation by migrating from ClaimMetadataClientException to a more structured APIError approach with enhanced error messages and descriptions in the API response.
- Updated error handling methods to use
handleClaimManagementClientErrorinstead of direct exception throwing - Enhanced error messages for better clarity and user understanding
- Removed unused input type constant and improved SCIM mapping validation logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ServerClaimManagementService.java | Refactored exception handling to use structured API errors and improved validation logic |
| Constant.java | Updated error message descriptions for better clarity and user experience |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java
Show resolved
Hide resolved
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java
Show resolved
Hide resolved
...mmon/src/main/java/org/wso2/carbon/identity/api/server/claim/management/common/Constant.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/org/wso2/carbon/identity/api/server/claim/management/common/Constant.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/org/wso2/carbon/identity/api/server/claim/management/common/Constant.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/17170729061
Purpose
Related Issues
The API response will have the error message and description.