-
Notifications
You must be signed in to change notification settings - Fork 168
Support for actionId and handle components in REDIRECT steps #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...tion.v1/src/main/java/org/wso2/carbon/identity/api/server/flow/execution/v1/utils/Utils.java
Show resolved
Hide resolved
...tion.v1/src/main/java/org/wso2/carbon/identity/api/server/flow/execution/v1/utils/Utils.java
Show resolved
Hide resolved
AI Agent Log Improvement Checklist
✅ Before merging this pull request:
|
|
PR builder started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for an actionId field to the Component model, enhancing button component handling in REDIRECT steps. The changes enable better identification and tracking of button actions within the flow execution system.
- Added
actionIdfield to Component model with proper getter, setter, and builder methods - Enhanced conversion logic to automatically set
actionIdfor button components and handle components in REDIRECT steps - Updated OpenAPI documentation and example values for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flow-execution.yaml | Added actionId field definition and updated example values |
| Utils.java | Enhanced component conversion and added REDIRECT step component handling |
| FlowExecutionRequest.java | Updated example value for actionId annotation |
| Component.java | Added actionId field with complete implementation including equals/hashCode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...tion.v1/src/main/java/org/wso2/carbon/identity/api/server/flow/execution/v1/utils/Utils.java
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
Merging as all the test runners have been success in the last integration test run - https://github.com/wso2/product-is/actions/runs/17199599469 |
|
PR builder completed |
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/17199599469
|
PR builder completed |
Related Issue
wso2/product-is#25415
This pull request introduces support for an
actionIdfield in theComponentmodel, ensuring that button components have a clear action identifier. The changes update both the Java code and the OpenAPI YAML definitions to reflect this new field and standardize example values. Additionally, the conversion utility logic is enhanced to automatically set theactionIdfor button components.Component Model Enhancements
actionIdfield to theComponentclass, including its getter, setter, builder method, and relevant annotations. This field is now included in equality, hash, and string representation methods. [1] [2] [3] [4] [5]Conversion Logic Improvements
Utils.convertToComponentto automatically set theactionIdfor button components based on theirid.Utils.convertToData.API Documentation Updates
flow-execution.yaml) to include the newactionIdfield for components and standardized example values for bothidandactionId. [1] [2]idandactionIdin Java model annotations for consistency with the API documentation. [1] [2]