Add revert API for impersonation configurations. #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+448
to
+450
| public void deleteImpersonationConfiguration() { | ||
|
|
||
| String tenantDomain = ContextLoader.getTenantDomainFromContext(); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| public void deleteImpersonationConfiguration() { | |
| String tenantDomain = ContextLoader.getTenantDomainFromContext(); | |
| public void deleteImpersonationConfiguration() { | |
| String tenantDomain = ContextLoader.getTenantDomainFromContext(); | |
| log.info("Deleting impersonation configuration for tenant domain: " + tenantDomain); |
.../java/org/wso2/carbon/identity/api/server/configs/v1/core/ServerConfigManagementService.java
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/api/server/configs/v1/core/ServerConfigManagementService.java
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/api/server/configs/v1/impl/ConfigsApiServiceImpl.java
Show resolved
Hide resolved
AI Agent Log Improvement Checklist
✅ Before merging this pull request:
|
AnuradhaSK
reviewed
Sep 1, 2025
.../java/org/wso2/carbon/identity/api/server/configs/v1/core/ServerConfigManagementService.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Sep 1, 2025
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/17381806494
AnuradhaSK
approved these changes
Sep 1, 2025
Yasasr1
added a commit
that referenced
this pull request
Sep 3, 2025
[Sync][master -> next][#977]: Add revert API for impersonation configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Depends on
Related issue