Skip to content

Conversation

@sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Sep 8, 2025

Purpose

Define date and epoch as first class supported data types of the product.

Related Issues

When handling date & time related data, having only the date_time data type leads to complexities in processing as it can be either date, date with time or an epoch time. Those time formats are widely used formats and used for different scenarios. The UX for such data types also different.

  • date -> date picker
  • dateTime -> date time pickers
  • epoch -> Text

There should be first class identifier about the type of the data, then we can provide support to define the patterns if the current pattern not align with the ISO formats of the above defined types.

.
.

"dataType" : "date",
"inputFormat": {
      "pattern": "DD-MM-YYYY",
      "inputType": "date_picker"
},
.
.

Copilot AI review requested due to automatic review settings September 8, 2025 13:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for date and epoch data types as first-class data types in the claim management system, replacing the previous date_time validation with a more specific date validation.

  • Added DATE and EPOCH enum values to the DataType enumeration
  • Updated validation logic to check for DATE data type instead of DATE_TIME when using date_picker input format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
DataType.java Added DATE and EPOCH enum constants with documentation
ServerClaimManagementService.java Updated validation to use DATE instead of DATE_TIME for date_picker input format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sadilchamishka
Copy link
Contributor Author

sadilchamishka commented Sep 8, 2025

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/17569595541

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/17569595541
Status: failure

@sadilchamishka sadilchamishka merged commit 6b00229 into wso2:master Sep 9, 2025
3 checks passed
sadilchamishka added a commit that referenced this pull request Sep 9, 2025
[Sync][master -> next][#987]: Provide the date and epoch data type support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants