Skip to content

Conversation

@sadilchamishka
Copy link
Contributor

Purpose

$subject

Copilot AI review requested due to automatic review settings September 11, 2025 09:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation to limit the number of properties that can be configured for federated authenticators in identity providers, enforcing a configurable maximum limit.

Key changes:

  • Added validation during IDP creation and federated authenticator updates to check property count limits
  • Introduced a new error code for when the maximum property limit is exceeded
  • Added a configurable constant for the maximum federated authenticator property limit

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ServerIdpManagementService.java Adds validation methods and calls to enforce property limits during IDP creation and authenticator updates
Constants.java Defines the configuration property name and error message for property limit validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sadilchamishka
Copy link
Contributor Author

@sadilchamishka sadilchamishka merged commit ea288ed into wso2:master Sep 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants