Remove the hardcoded flow type from the flow API execution#10188
Remove the hardcoded flow type from the flow API execution#10188DilshanSenarath wants to merge 2 commits intowso2:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaces a hardcoded Changes
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@identity-apps-core/apps/accounts/src/main/webapp/execution-flow.jsp`:
- Line 501: The flowType state is initialized to the literal string "null" which
can be sent as an invalid flowType; change the initial default to a true
null/empty value and update the logic that reads the initial URL param so
setFlowType(null) is used when no param is present; ensure any code that
constructs the request payload (the object using flowType) skips or omits the
flowType field when the state is null/empty. Target symbols: the flowType state
variable, the setFlowType setter, and the request-creation site where flowType:
flowType is included so invalid "null" is never sent to the backend.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 54eb0388-33b2-4325-8a68-af0d676a24ab
📒 Files selected for processing (1)
identity-apps-core/apps/accounts/src/main/webapp/execution-flow.jsp
Purpose
Related Issue