Skip to content

Remove the hardcoded flow type from the flow API execution#10188

Open
DilshanSenarath wants to merge 2 commits intowso2:masterfrom
DilshanSenarath:password-reset-issue
Open

Remove the hardcoded flow type from the flow API execution#10188
DilshanSenarath wants to merge 2 commits intowso2:masterfrom
DilshanSenarath:password-reset-issue

Conversation

@DilshanSenarath
Copy link
Copy Markdown
Contributor

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 0a6ba95b-6d95-4e79-bbf9-901b41f2f8ce

📥 Commits

Reviewing files that changed from the base of the PR and between d4091ac and b0c462b.

📒 Files selected for processing (1)
  • .changeset/red-ways-do.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/red-ways-do.md

📝 Walkthrough

Walkthrough

Replaces a hardcoded flowType value with a dynamic flowType variable in the React handleFlowRequest payload so subsequent flow step requests use the flow type stored in component state (including updates from prior API responses).

Changes

Cohort / File(s) Summary
Flow Type Handling
identity-apps-core/apps/accounts/src/main/webapp/execution-flow.jsp
Replaced flowType: "REGISTRATION" with flowType: flowType when constructing the request payload in handleFlowRequest, so the current state-held flow type is sent with subsequent flow execution requests.
Changeset Metadata
.changeset/red-ways-do.md
Added a changeset patch bump for @wso2is/identity-apps-core noting removal of the hardcoded flow type; contains only metadata and a descriptive note, no runtime code changes.
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete. While it includes Purpose and a Related Issue link, it is missing most required sections from the template including Related PRs, comprehensive checklists, security checks, and developer checklist items. Complete the description by filling out all required template sections including the Checklist, Security checks, and Developer Checklist with appropriate status indicators.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing hardcoded flow type from flow API execution, which matches the primary code modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Changeset Required ✅ Passed The pull request includes a valid changeset file (.changeset/red-ways-do.md) that properly documents changes to @wso2is/identity-apps-core with a patch version update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@identity-apps-core/apps/accounts/src/main/webapp/execution-flow.jsp`:
- Line 501: The flowType state is initialized to the literal string "null" which
can be sent as an invalid flowType; change the initial default to a true
null/empty value and update the logic that reads the initial URL param so
setFlowType(null) is used when no param is present; ensure any code that
constructs the request payload (the object using flowType) skips or omits the
flowType field when the state is null/empty. Target symbols: the flowType state
variable, the setFlowType setter, and the request-creation site where flowType:
flowType is included so invalid "null" is never sent to the backend.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 54eb0388-33b2-4325-8a68-af0d676a24ab

📥 Commits

Reviewing files that changed from the base of the PR and between 4430ef9 and d4091ac.

📒 Files selected for processing (1)
  • identity-apps-core/apps/accounts/src/main/webapp/execution-flow.jsp

Comment thread identity-apps-core/apps/accounts/src/main/webapp/execution-flow.jsp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant