Skip to content

Update the force password reset config page with new configurations. #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Apr 4, 2025

Purpose

  • $subject.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Preview

Configuration page

image

Password reset model while email OTP enabled

force password otp enabled

Password reset model while SMS OTP enabled.

image

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (1ab7eb6) to head (414ada5).
Report is 216 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7995   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          42       42           
  Lines         939      939           
  Branches      231      238    +7     
=======================================
  Hits          393      393           
- Misses        502      527   +25     
+ Partials       44       19   -25     
Flag Coverage Δ
@wso2is/core 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • features/admin.server-configurations.v1/forms/admin-forced-password-reset-form/admin-forced-password-reset-form.scss: Language not supported
Comments suppressed due to low confidence (1)

features/admin.server-configurations.v1/forms/admin-forced-password-reset-form/admin-forced-password-reset-form.tsx:177

  • Avoid double-wrapping the translation function 't()'; the inner call already returns the translated string and passing it again to 't()' is redundant and may lead to unexpected results.
                    { t( t("extensions:manage.serverConfigurations.accountRecovery.forcedPasswordRecovery.form.subheading")) }

DonOmalVindula
DonOmalVindula previously approved these changes Apr 22, 2025
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@DonOmalVindula DonOmalVindula merged commit 417119a into wso2:master Apr 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants