Update authserver hotsname #144
Conversation
WalkthroughThe Helm values configuration for the identity server has been updated to change the host endpoint from an internal service reference to an external domain and remove the port specification. This modifies the CDS service's identity server connectivity settings. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
install/helm/values.yaml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Lakshan-Banneheke
Repo: wso2/identity-customer-data-service PR: 90
File: install/helm/templates/cds-env-secret.yaml:27-33
Timestamp: 2025-12-02T04:49:53.790Z
Learning: In the identity-customer-data-service project, secrets referenced in install/helm/templates/cds-env-secret.yaml are managed via Azure Key Vault and injected from the deployment pipeline, not hardcoded in values.yaml.
📚 Learning: 2025-12-02T04:49:53.790Z
Learnt from: Lakshan-Banneheke
Repo: wso2/identity-customer-data-service PR: 90
File: install/helm/templates/cds-env-secret.yaml:27-33
Timestamp: 2025-12-02T04:49:53.790Z
Learning: In the identity-customer-data-service project, secrets referenced in install/helm/templates/cds-env-secret.yaml are managed via Azure Key Vault and injected from the deployment pipeline, not hardcoded in values.yaml.
Applied to files:
install/helm/values.yaml
| host: dev.api.asgardeo.io | ||
| port: "" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cd install/helm && ls -la | grep valuesRepository: wso2/identity-customer-data-service
Length of output: 139
🏁 Script executed:
rg -n 'identityServer' install/helm/values.yamlRepository: wso2/identity-customer-data-service
Length of output: 105
🏁 Script executed:
rg -n 'port.*identityServer|identityServer.*port' --type yamlRepository: wso2/identity-customer-data-service
Length of output: 187
🏁 Script executed:
find install/helm -type f -name "values*.yaml" | head -20Repository: wso2/identity-customer-data-service
Length of output: 103
🏁 Script executed:
rg -rn 'identityServer\.' --type yaml --type jsonRepository: wso2/identity-customer-data-service
Length of output: 1351
🏁 Script executed:
rg -rn '\.port|port:' --type js --type ts --type java --type go --type python -C 2 | head -100Repository: wso2/identity-customer-data-service
Length of output: 109
🏁 Script executed:
rg -rn 'identityServer' --type js --type ts --type java --type go --type python -C 2 | head -100Repository: wso2/identity-customer-data-service
Length of output: 109
🏁 Script executed:
cat -n install/helm/values.yamlRepository: wso2/identity-customer-data-service
Length of output: 4095
🏁 Script executed:
cat -n install/helm/confs/deployment.yamlRepository: wso2/identity-customer-data-service
Length of output: 3512
🏁 Script executed:
cat -n install/helm/templates/cds-deployment.yaml | head -100Repository: wso2/identity-customer-data-service
Length of output: 4821
🏁 Script executed:
fd -n values deploy test -t f | grep -E "values.*\.yaml|override"Repository: wso2/identity-customer-data-service
Length of output: 309
🏁 Script executed:
rg -rn "values.*=.*dev|environment.*override" --type yaml --type json | head -20Repository: wso2/identity-customer-data-service
Length of output: 61
🏁 Script executed:
cat -n install/helm/templates/cds-config.yaml 2>/dev/null || echo "File not found"Repository: wso2/identity-customer-data-service
Length of output: 1259
🏁 Script executed:
find . -name "*.yaml" -path "*/helm/*" | head -20Repository: wso2/identity-customer-data-service
Length of output: 511
🏁 Script executed:
cat -n install/helm/Chart.yamlRepository: wso2/identity-customer-data-service
Length of output: 1195
🏁 Script executed:
find . -name "values*.yaml" -o -name "*values*.yaml" | grep helmRepository: wso2/identity-customer-data-service
Length of output: 105
🏁 Script executed:
git ls-files install/helm | grep -E "values|override|env"Repository: wso2/identity-customer-data-service
Length of output: 146
🏁 Script executed:
cat -n install/helm/templates/cds-env-secret.yamlRepository: wso2/identity-customer-data-service
Length of output: 1818
Confirm empty port handling and environment defaults are passed to application as-is.
-
Empty port rendered as null: The templated configuration will pass an empty/null port value to the application (deployment.yaml line 22). Verify the application correctly handles null port and defaults to HTTPS port (443) when constructing identity server URLs.
-
Dev-specific configuration in chart defaults: This Helm chart contains hardcoded dev environment settings (env: "dev" at line 27 and identityServer.host: "dev.api.asgardeo.io"). For production deployments, ensure these values are overridden at deployment time via
-f values-prod.yamlor--setflags. -
Architectural change from internal to external service: This shifts from an internal Kubernetes service to an external domain. Verify:
- Network connectivity and firewall rules permit outbound HTTPS to
dev.api.asgardeo.io - Certificate validation works with the external domain
- All OAuth2 endpoints (introspection, token, revocation, claims) are accessible
- Network connectivity and firewall rules permit outbound HTTPS to
🤖 Prompt for AI Agents
In install/helm/values.yaml around lines 48-49, the identityServer.port is empty
which will render null in the chart and you also have dev-specific defaults
(env: "dev" and host: "dev.api.asgardeo.io"); ensure the app receives a usable
port and production-safe defaults by (1) updating the Helm template or values to
coalesce an empty/null port to 443 (or document that the app will default to
443) so identity URLs are built correctly, (2) removing or clearly marking
dev-only defaults and adding instructions/comments to require overriding env and
host via values-prod.yaml or --set at deploy time, and (3) validating the
architectural change from internal->external by running outbound HTTPS
connectivity and TLS validation to dev.api.asgardeo.io and exercising all OAuth2
endpoints (introspect/token/revoke/claims) from cluster egress; make these
changes or add deploy-time checks/docs so production deployments won’t break.
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.