-
Notifications
You must be signed in to change notification settings - Fork 12
Add BI logs support #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BI logs support #248
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| resource function post logs(http:Request request, types:ICPLogEntryRequest logRequest) returns types:LogEntriesResponse|error { | ||
| log:printInfo("Received log request: " + logRequest.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log Improvement Suggestion No: 1
| resource function post logs(http:Request request, types:ICPLogEntryRequest logRequest) returns types:LogEntriesResponse|error { | |
| log:printInfo("Received log request: " + logRequest.toString()); | |
| resource function post logs(http:Request request, types:ICPLogEntryRequest logRequest) returns types:LogEntriesResponse|error { | |
| log:printInfo("Received log request for components: " + (logRequest.componentIdList ?: [logRequest.componentId ?: "none"]).toString() + ", environments: " + (logRequest.environmentList ?: [logRequest.environmentId ?: "none"]).toString()); |
|
|
||
| // Invoke observability adapter service | ||
| return check observabilityClient->post("/observability/logs/", adaptorRequest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log Improvement Suggestion No: 2
| // Invoke observability adapter service | |
| return check observabilityClient->post("/observability/logs/", adaptorRequest); | |
| // Invoke observability adapter service | |
| types:LogEntriesResponse response = check observabilityClient->post("/observability/logs/", adaptorRequest); | |
| log:printInfo("Successfully retrieved " + response.rows.length().toString() + " log entries"); | |
| return response; |
| public type ICPLogEntryRequest record { | ||
| string componentId?; | ||
| string[] componentIdList?; | ||
| string environmentId?; | ||
| string[] versionIdList?; | ||
| string[] environmentList?; | ||
| string[] logLevels?; | ||
| string region?; | ||
| string searchPhrase?; | ||
| string regexPhrase?; | ||
| string startTime?; | ||
| string endTime?; | ||
| int 'limit = 100; | ||
| LogEntryRequestSort sort = "asc"; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log Improvement Suggestion No: 3
| public type ICPLogEntryRequest record { | |
| string componentId?; | |
| string[] componentIdList?; | |
| string environmentId?; | |
| string[] versionIdList?; | |
| string[] environmentList?; | |
| string[] logLevels?; | |
| string region?; | |
| string searchPhrase?; | |
| string regexPhrase?; | |
| string startTime?; | |
| string endTime?; | |
| int 'limit = 100; | |
| LogEntryRequestSort sort = "asc"; | |
| }; | |
| string componentId?; | |
| string[] componentIdList?; | |
| string environmentId?; | |
| string[] environmentList?; | |
| string[] logLevels?; | |
| string region?; | |
| string searchPhrase?; | |
| string regexPhrase?; | |
| string startTime?; | |
| string endTime?; | |
| int 'limit = 100; | |
| LogEntryRequestSort sort = "asc"; | |
| }; | |
| log:info("ICPLogEntryRequest record type initialized with default limit: 100 and sort: asc"); |
| public type LogEntryRequest record { | ||
| string[] runtimeIdList = []; | ||
| string[] logLevels?; | ||
| string region?; | ||
| string searchPhrase?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log Improvement Suggestion No: 4
| public type LogEntryRequest record { | |
| string[] runtimeIdList = []; | |
| string[] logLevels?; | |
| string region?; | |
| string searchPhrase?; | |
| public type LogEntryRequest record { | |
| string[] runtimeIdList = []; | |
| string[] logLevels?; | |
| string region?; | |
| string searchPhrase?; | |
| log:info("LogEntryRequest record type initialized with empty runtimeIdList"); |
| resource function post logs(@http:Header {name: "X-API-Key"} string? apiKeyHeader, http:Request request, types:LogEntryRequest logRequest) returns types:LogEntriesResponse|error { | ||
| log:printInfo("Received log request for component: " + logRequest.componentId); | ||
| log:printInfo("Received log request for component: " + logRequest.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log Improvement Suggestion No: 5
| resource function post logs(@http:Header {name: "X-API-Key"} string? apiKeyHeader, http:Request request, types:LogEntryRequest logRequest) returns types:LogEntriesResponse|error { | |
| log:printInfo("Received log request for component: " + logRequest.componentId); | |
| log:printInfo("Received log request for component: " + logRequest.toString()); | |
| log:printInfo("Received log request for component: " + logRequest.componentId); | |
| log:printDebug("Received log request: runtimeIds=" + logRequest.runtimeIdList.toString() + ", logLevels=" + (logRequest.logLevels != null ? logRequest.logLevels.toString() : "null")); |
| // Filter by runtime IDs if specified | ||
| string[] runtimeIds = logRequest.runtimeIdList; | ||
| if (runtimeIds.length() > 0) { | ||
| mustClauses.push({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log Improvement Suggestion No: 6
| // Filter by runtime IDs if specified | |
| string[] runtimeIds = logRequest.runtimeIdList; | |
| if (runtimeIds.length() > 0) { | |
| mustClauses.push({ | |
| // Filter by runtime IDs if specified | |
| string[] runtimeIds = logRequest.runtimeIdList; | |
| if (runtimeIds.length() > 0) { | |
| log:printDebug("Filtering logs by runtime IDs: " + runtimeIds.toString()); | |
| mustClauses.push({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Purpose