Unify multi-project configure destination UX#1279
Conversation
Add required marker, default path fallback, and fix field focus for multi-project step to match single-project behavior
📝 WalkthroughWalkthroughThe MultiProjectFormFields component now implements asynchronous initialization logic for the path field. When 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai Please review |
|
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@wi/wi-webviews/src/views/ImportIntegration/components/MultiProjectFormFields.tsx`:
- Around line 64-76: The effect that sets a default path (useEffect) can race
with user input and currently doesn't fallback to getDefaultCreationPath() when
getWorkspaceRoot() fails; update the effect to accept a cancellation flag (e.g.,
let cancelled = false or isMounted) and return a cleanup that flips it so any
async result is ignored if the user has since changed formData.path, call
wsClient.getWorkspaceRoot() inside try/catch and if that fails call
wsClient.getDefaultCreationPath() as a fallback, only call onFormDataChange({
path }) when !cancelled and formData.path is still falsy to avoid overwriting a
user selection, and change the dependency array to [formData.path,
onFormDataChange, wsClient].
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: afbe0610-2c6b-433e-975c-002b14dc1311
📒 Files selected for processing (1)
wi/wi-webviews/src/views/ImportIntegration/components/MultiProjectFormFields.tsx
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
@coderabbitai I addressed the previous suggestion. Please re-review. |
|
The PR description image shows the updated Configure Destination step (step 3) in the migration wizard. The UI now displays:
This visually confirms the intent of the PR: unified required-field indicators, default path population, and corrected focus behavior. I'll trigger a full re-review of the changes now.
✅ Actions performedFull review triggered. |
Purpose
$subject.
Fixes #1053
Sample:
