Integration test for custom authenticator in internal user login success flow #23661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indeewari
changed the title
malithie
reviewed
Apr 3, 2025
| @@ -0,0 +1,583 @@ | |||
| package org.wso2.identity.integration.test.rest.api.server.authenticator.execution.v1; | |||
There was a problem hiding this comment.
This is an integration test for the authenticator execution flow right ? why we have this under rest.api.server package ?
malithie
reviewed
Apr 3, 2025
Comment on lines
+328
to
+334
| /** | ||
| * Extracts the JWT claims set from a given JWT token. | ||
| * | ||
| * @param jwtToken JWT token from which claims are to be extracted | ||
| * @return JWTClaimsSet extracted from the provided JWT token | ||
| * @throws ParseException If there is an error in parsing the JWT token | ||
| */ |
There was a problem hiding this comment.
IMO we don't need these comments. Method is self explanatory
malithie
reviewed
Apr 3, 2025
| * @param consumerSecret Consumer secret of the application. | ||
| * @return Base 64 encoded string. | ||
| */ | ||
| public String getBase64EncodedString(String consumerKey, String consumerSecret) { |
There was a problem hiding this comment.
why is this public ? Also check if there's any util
malithie
reviewed
Apr 3, 2025
| return customAuthenticatorAuthRQ; | ||
| } | ||
|
|
||
| public HttpResponse sendGetRequest(HttpClient client, String locationURL) throws IOException { |
There was a problem hiding this comment.
I don't think any of these methods should be public
malithie
reviewed
Apr 3, 2025
| AUTHENTICATOR_CONFIG_API_BASE_PATH + customIdPId, tenant))); | ||
| } | ||
|
|
||
| protected UserDefinedLocalAuthenticatorConfig createBaseUserDefinedLocalAuthenticator( |
There was a problem hiding this comment.
Are we expecting this test to be extended ?
malithie
reviewed
Apr 3, 2025
| private String identityProviderBaseUrl; | ||
| private UserDTO internalUser; | ||
|
|
||
| public void start(String identityProviderBaseUrl, UserDTO internalUser) { |
There was a problem hiding this comment.
Should we say internalUser ?
I think the same service can be used to model other cases as well
malithie
reviewed
Apr 3, 2025
Comment on lines
+50
to
+51
| System.out.println("Received Request: " + request); | ||
| System.out.println("Response Sent: " + response.getBodyAsString()); |
There was a problem hiding this comment.
Can't we use some logger here than sys out ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the success path for setting up and authenticating a consumer user using a custom authenticator for
Internal User Identification Authenticators.Parent issue: