Fix minor bugs in OIDC conformance tests

[hwupathum]

This pull request updates the OIDC conformance test workflow to simplify input handling and improve messaging formatting. The main changes focus on removing the unused download-url input, updating logic to consistently use the tag input, and refining the chat message output.

Workflow input and logic simplification:

• Removed the download-url input from the workflow and updated descriptions for the tag input to clarify its usage.
• Refactored resource selection logic in workflow jobs to use tag exclusively, defaulting to "built-from-latest-source" or "built from latest source" when not provided, and eliminated references to download-url. [1] [2]

Messaging improvements:

• Fixed the formatting of the workflow status message in send_chat.py by ensuring proper HTML line breaks and bold/colored status text.

Summary by CodeRabbit

• Bug Fixes

  • Improved formatting of test status messages in chat notifications.

• Chores

  • Enhanced clarity of release tag information in conformance test notifications to better distinguish between latest source builds and specific release versions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Three files are modified to adjust workflow automation and notification formatting. The FAPI OIDC workflow has indentation changes, the OIDC workflow updates tag input descriptions and introduces INPUT_TAG-based RESOURCE derivation for notifications, and the chat notification script adjusts HTML formatting.

Changes

Cohort / File(s)	Summary
Workflow Configuration \`.github/workflows/fapi-oidc-conformance-test.yml``, ``.github/workflows/oidc-conformance-test.yml```	Indentation adjustments for RESOURCE variable derivation in FAPI workflow. OIDC workflow: tag input description clarified to indicate it's a release tag with latest as default; INPUT_TAG introduced and used to conditionally set RESOURCE for email and chat notifications; download-url input description removed.
Chat Notification Formatting \`oidc-conformance-tests/send_chat.py```	HTML formatting corrected in status line: closes font and bold tags before "Failed test cases" section with added line break.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With workflows refined and tags made clear,
INPUT_TAG now leads the way here,
HTML tags properly closed with care,
Notifications formatted, debugged and fair! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: fixing minor bugs related to OIDC conformance test workflows, including input handling and message formatting.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

oidc-conformance-tests/send_chat.py (1)

85-85: HTML formatting fix looks correct.

The addition of </font></b></br>\n properly closes the tags opened on Line 84 and adds a line break before the "Failed test cases" text, which aligns with the PR's goal to improve message formatting.

♻️ Optional: Simplify f-string conversions

The explicit str() calls in f-strings on lines 85-86 are unnecessary since f-strings automatically convert values to strings:

-                                f"</font></b></br>\nFailed test cases: {str(failed_count)}" 
-                                f"\nTest cases with errors: {str(errors_count)}"
+                                f"</font></b></br>\nFailed test cases: {failed_count}" 
+                                f"\nTest cases with errors: {errors_count}"

.github/workflows/oidc-conformance-test.yml (1)

267-272: LGTM! INPUT_TAG-based RESOURCE derivation is correct.

The logic properly derives the RESOURCE value for chat notifications. Note that the chat context uses "built from latest source" (with spaces) while the email context uses "built-from-latest-source" (with hyphens). This difference may be intentional for display formatting in different notification contexts.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b775435 and 3bff12b.

📒 Files selected for processing (3)

• .github/workflows/fapi-oidc-conformance-test.yml
• .github/workflows/oidc-conformance-test.yml
• oidc-conformance-tests/send_chat.py

🧰 Additional context used

🪛 Ruff (0.14.10)

oidc-conformance-tests/send_chat.py

85-85: Use explicit conversion flag

Replace with conversion flag

(RUF010)

🔇 Additional comments (3)

.github/workflows/fapi-oidc-conformance-test.yml (1)

321-325: LGTM! Indentation improvements enhance readability.

The indentation adjustments improve code readability without altering the logic. The RESOURCE derivation correctly defaults to "built from latest source" when no tag is provided.

.github/workflows/oidc-conformance-test.yml (2)

17-17: LGTM! Clearer input description.

The updated description clearly specifies the expected format and fallback behavior, improving user experience when manually triggering the workflow.

---

242-247: LGTM! INPUT_TAG-based RESOURCE derivation is correct.

The logic properly derives the RESOURCE value for email notifications, defaulting to "built-from-latest-source" when no tag is provided. This aligns with the PR's objective to use the tag input exclusively.