Skip to content

Move application management integration test cases for corresponding test classes#27403

Open
sadilchamishka wants to merge 1 commit intoarchive_IS-7.3from
refactor-integration-test-of-application-mgt
Open

Move application management integration test cases for corresponding test classes#27403
sadilchamishka wants to merge 1 commit intoarchive_IS-7.3from
refactor-integration-test-of-application-mgt

Conversation

@sadilchamishka
Copy link
Copy Markdown
Contributor

@sadilchamishka sadilchamishka commented Apr 3, 2026

$subject

Summary by CodeRabbit

  • Tests
    • Reorganized test configuration to reallocate test cases across different test suites, optimizing test execution management.

Copilot AI review requested due to automatic review settings April 3, 2026 08:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 198f9ec4-e76a-414f-b097-9f5551b858b1

📥 Commits

Reviewing files that changed from the base of the PR and between 77c0da8 and 40aac63.

📒 Files selected for processing (1)
  • modules/integration/tests-integration/tests-backend/src/test/resources/testng.xml

Walkthrough

TestNG configuration reorganization: two test cases (ApplicationTemplateMgtTestCase and ApplicationPatchTest) were relocated between test suites, moving from is-tests-saas-app-creation to is-tests-default-configuration and is-test-rest-api respectively.

Changes

Cohort / File(s) Summary
TestNG Configuration
modules/integration/tests-integration/tests-backend/src/test/resources/testng.xml
Reorganized test case suite assignments: migrated ApplicationTemplateMgtTestCase to is-tests-default-configuration and ApplicationPatchTest to is-test-rest-api, removing both from is-tests-saas-app-creation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Tests hop to new homes so fine,
From SaaS to REST, default lines align,
Configuration dances, suite by suite,
Templates and patches find retreat! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: moving application management integration test cases to their corresponding test classes, which aligns with the file changes in testng.xml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor-integration-test-of-application-mgt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jenkins-is-staging
Copy link
Copy Markdown
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/23939691514

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes TestNG suite composition for application management-related integration tests, relocating specific test classes to more appropriate <test> blocks in the main integration TestNG suite.

Changes:

  • Moved ApplicationTemplateMgtTestCase into the is-tests-default-configuration block.
  • Moved ApplicationPatchTest into the main server application management REST API test block.
  • Removed both classes from is-tests-saas-app-creation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 558 to 561
<test name="is-tests-saas-app-creation" preserve-order="true" parallel="false" group-by-instances="true">
<classes>
<class name="org.wso2.identity.integration.test.application.mgt.SaasAppCreationInitializerTestCase"/>
<class name="org.wso2.identity.integration.test.application.mgt.ApplicationTemplateMgtTestCase"/>
<class name="org.wso2.identity.integration.test.rest.api.server.application.management.v1.ApplicationPatchTest"/>
</classes>
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is-tests-saas-app-creation now contains only SaasAppCreationInitializerTestCase. Since that class enables a config, restarts the server, and restores the config in @AfterTest, this block becomes an expensive no-op (extra restart + potential flakiness) with no tests benefiting from the enabled setting. Consider removing this <test> block entirely, or keep at least one test class in this block that actually requires enable_app_creation=true.

Copilot uses AI. Check for mistakes.
<class name="org.wso2.identity.integration.test.scim.SCIMServiceProviderUserTestCase"/>
<class name="org.wso2.identity.integration.test.scim.SCIMServiceProviderGroupTestCase"/>
<class name="org.wso2.identity.integration.test.application.mgt.ImportExportServiceProviderTest"/>
<class name="org.wso2.identity.integration.test.application.mgt.ApplicationTemplateMgtTestCase"/>
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is currently the placeholder $subject, which doesn’t explain the motivation/impact of moving these test classes between TestNG blocks (e.g., ordering/config assumptions, CI runtime impact). Please update the PR description to briefly state why the move is needed and what suite(s) these tests should belong to.

Copilot uses AI. Check for mistakes.
@sadilchamishka
Copy link
Copy Markdown
Contributor Author

@jenkins-is-staging
Copy link
Copy Markdown
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/23939691514
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants