On XML parsing failure, handle the HTML Registry content as plain text #4459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
+269
to
+270
| } catch (OMException | XMLStreamException ignored) { | ||
| result = treatContentAsNonXmlOnXmlError(url); |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| } catch (OMException | XMLStreamException ignored) { | |
| result = treatContentAsNonXmlOnXmlError(url); | |
| } catch (OMException | XMLStreamException ignored) { | |
| log.warn("Failed to parse content as XML from URL: " + url.toString()); | |
| result = treatContentAsNonXmlOnXmlError(url); |
Comment on lines
+278
to
+280
| result = treatContentAsNonXmlOnXmlError(url); | ||
| } else { | ||
| throw runtimeException; |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| result = treatContentAsNonXmlOnXmlError(url); | |
| } else { | |
| throw runtimeException; | |
| result = treatContentAsNonXmlOnXmlError(url); | |
| } else { | |
| log.error("Unexpected runtime exception while parsing XML: " + runtimeException.getMessage()); | |
| throw runtimeException; |
Contributor
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #4451