-
Notifications
You must be signed in to change notification settings - Fork 276
Set additional logging param to append the original backend #3745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
...rcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/grpc/ExtAuthService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 |
0eed02c to
daeae5a
Compare
|
[succeeded] : dev-deployment-v2 : 20251127.6 |
|
[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20251127.6 |
| "respDur": "%RESPONSE_DURATION%", | ||
| "apiUuid": "%DYNAMIC_METADATA(envoy.filters.http.ext_authz:apiUUID)%", | ||
| "extAuthDtls": "%DYNAMIC_METADATA(envoy.filters.http.ext_authz:extAuthDetails)%", | ||
| "resourcePath": "%DYNAMIC_METADATA(envoy.filters.http.ext_authz:resourcePath)%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update ReservedLogFormat too
|
[succeeded] Dataplane(EastUS) cluster : dev-deployment-v2 : 20251202.7 |
|
[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20251203.4 |
1 similar comment
|
[failed] Dataplane(EastUS) cluster : stage-deployment-v2 : 20251203.4 |
|
[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20251205.1 |
1 similar comment
|
[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20251205.1 |
|
[] Controlplane cluster : stage-deployment-v2 : 20251208.3 |
|
[] Dataplane(EastUS) cluster : stage-deployment-v2 : 20251208.3 |
|
[canceled] Dataplane(EastUS) cluster : prod-deployment-v2 : 20251209.1 |
|
[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20251209.1 |
|
[succeeded] Controlplane cluster : prod-deployment-v2 : 20251209.1 |
|
[failed] Dataplane(EastUS) cluster : prod-deployment-v2 : 20251209.1 |
|
[succeeded] Controlplane cluster : prod-deployment-v2 : 20251209.1 |
|
[] Controlplane cluster : prod-deployment-v2 : 20251210.2 |
Purpose
Issues
Fixes https://github.com/wso2-enterprise/choreo/issues/37272
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge