Fix font lib issue in windows #1071
Conversation
WalkthroughIcon glyph definitions updated in three VS Code extension manifests and the fantasticon devDependency version changed in the font library package; no functional or behavioral code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… fix-storybook
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
common/config/rush/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
workspaces/ballerina/ballerina-extension/package.json(2 hunks)workspaces/choreo/choreo-extension/package.json(1 hunks)workspaces/common-libs/font-wso2-vscode/package.json(1 hunks)workspaces/mi/mi-extension/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-25T06:34:10.812Z
Learnt from: CR
Repo: wso2/vscode-extensions PR: 0
File: workspaces/ballerina/component-diagram/AGENTS.md:0-0
Timestamp: 2025-11-25T06:34:10.812Z
Learning: Applies to workspaces/ballerina/component-diagram/src/resources/icons/**/*.tsx : Create separate SVG icon components in src/resources/icons/ for all diagram icons and import them as React components
Applied to files:
workspaces/ballerina/ballerina-extension/package.jsonworkspaces/choreo/choreo-extension/package.json
📚 Learning: 2025-11-25T06:34:10.812Z
Learnt from: CR
Repo: wso2/vscode-extensions PR: 0
File: workspaces/ballerina/component-diagram/AGENTS.md:0-0
Timestamp: 2025-11-25T06:34:10.812Z
Learning: Applies to workspaces/ballerina/component-diagram/src/**/*.{ts,tsx} : Define all constants (node types, sizing, spacing) in src/resources/constants.ts and import them where needed instead of hardcoding values
Applied to files:
workspaces/ballerina/ballerina-extension/package.json
📚 Learning: 2025-11-25T06:34:10.812Z
Learnt from: CR
Repo: wso2/vscode-extensions PR: 0
File: workspaces/ballerina/component-diagram/AGENTS.md:0-0
Timestamp: 2025-11-25T06:34:10.812Z
Learning: Applies to workspaces/ballerina/component-diagram/**/*.config.{js,ts} : Use minimatch-compatible glob patterns for file matching in build and test configuration files
Applied to files:
workspaces/ballerina/ballerina-extension/package.json
🔇 Additional comments (3)
workspaces/choreo/choreo-extension/package.json (1)
161-161: Verify icon glyph \f183 exists in regenerated font file.The icon character has been updated to
\f183. Please ensure the new glyph exists in the compiledwso2-vscode.wofffile post-build to avoid rendering failures.workspaces/mi/mi-extension/package.json (1)
966-966: Verify icon glyphs exist in regenerated font file.Two icon character values have been updated:
distro-design-view:\f19d(shared with ballerina-extension)distro-build-package:\f178Ensure both glyphs are present in the compiled
wso2-vscode.woffafter the font build completes.Also applies to: 973-973
workspaces/ballerina/ballerina-extension/package.json (1)
1014-1014: Verify all four icon glyphs exist in regenerated font file.Four icon character values have been updated:
distro-design-view:\f19d(consistent with MI extension)distro-start:\f213distro-debug:\f198distro-persist-diagram:\f1eeEnsure all glyphs are present in the compiled
wso2-vscode.woffafter the font build with the updated fantasticon version completes.Also applies to: 1021-1021, 1028-1028, 1042-1042
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
workspaces/ballerina/ballerina-extension/package.json (1)
1004-1004: Document the Windows font issue in the PR description.The PR description is largely placeholder text with no explanation of what Windows-specific issue these glyph updates fix (e.g., rendering bug, missing glyphs, font-loading failure on Windows). Update the PR description to clearly state the problem and how these changes resolve it, for future maintainability and clarity.
Also applies to: 1011-1011, 1018-1018, 1032-1032
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
common/config/rush/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
workspaces/ballerina/ballerina-extension/package.json(2 hunks)workspaces/mi/mi-extension/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- workspaces/mi/mi-extension/package.json
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-11-25T06:34:10.812Z
Learnt from: CR
Repo: wso2/vscode-extensions PR: 0
File: workspaces/ballerina/component-diagram/AGENTS.md:0-0
Timestamp: 2025-11-25T06:34:10.812Z
Learning: Applies to workspaces/ballerina/component-diagram/src/resources/icons/**/*.tsx : Create separate SVG icon components in src/resources/icons/ for all diagram icons and import them as React components
Applied to files:
workspaces/ballerina/ballerina-extension/package.json
📚 Learning: 2025-11-25T06:34:10.812Z
Learnt from: CR
Repo: wso2/vscode-extensions PR: 0
File: workspaces/ballerina/component-diagram/AGENTS.md:0-0
Timestamp: 2025-11-25T06:34:10.812Z
Learning: Applies to workspaces/ballerina/component-diagram/src/**/*.{ts,tsx} : Define all constants (node types, sizing, spacing) in src/resources/constants.ts and import them where needed instead of hardcoding values
Applied to files:
workspaces/ballerina/ballerina-extension/package.json
📚 Learning: 2025-11-25T06:34:10.812Z
Learnt from: CR
Repo: wso2/vscode-extensions PR: 0
File: workspaces/ballerina/component-diagram/AGENTS.md:0-0
Timestamp: 2025-11-25T06:34:10.812Z
Learning: Applies to workspaces/ballerina/component-diagram/**/*.config.{js,ts} : Use minimatch-compatible glob patterns for file matching in build and test configuration files
Applied to files:
workspaces/ballerina/ballerina-extension/package.json
📚 Learning: 2025-11-10T15:05:11.309Z
Learnt from: madushajg
Repo: wso2/vscode-extensions PR: 868
File: workspaces/bi/bi-extension/src/utils.ts:224-242
Timestamp: 2025-11-10T15:05:11.309Z
Learning: The workspaces/bi/bi-extension and workspaces/ballerina/ballerina-extension are separate VS Code extensions that are packaged and distributed independently, so they cannot share code via imports and must maintain their own implementations of common utilities.
Applied to files:
workspaces/ballerina/ballerina-extension/package.json
🔇 Additional comments (1)
workspaces/ballerina/ballerina-extension/package.json (1)
1000-1034: Verify font library contains new glyph positions before merge.The four icon fontCharacter values in ballerina-extension have been updated (\f19d, \f213, \f198, \f1ee), but without confirming the rebuilt font file (
wso2-vscode.woff) contains these new glyphs, the icons will fail to render.Additionally, resolve glyph consistency across extensions: api-designer-extension still references the old glyph code
\\f133fordistro-design-view, which conflicts with this update. Verify whether api-designer-extension should use the new glyph value or retain its old value intentionally. Note that choreo-extension does not define these icons (only hasdistro-choreo-2), so updates may not apply there.
2 participants
Purpose
Goals
Approach
UI Component Development
npm run storybookfrom the root directory to view current components.Manage Icons
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit
Style
Chores
✏️ Tip: You can customize this high-level summary in your review settings.