Skip to content

Conversation

@krystian-panek-vmltech
Copy link
Contributor

fixes #286

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes replication functionality to support both HTML and JSON response formats from AEM replication endpoints. The changes implement a unified response handling approach by introducing a common interface and adapting existing code to handle different content types.

  • Introduces a ResponseData interface to standardize response handling across different formats
  • Adds JSON response parsing capability to complement existing HTML response handling
  • Updates replication logic to automatically detect and handle both JSON and HTML responses based on content type

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/sling/response.go Defines common ResponseData interface for unified response handling
pkg/sling/json_response.go Implements JSON response parsing with ResponseData interface
pkg/sling/html_response.go Adds GetMessage method to HTMLData to implement ResponseData interface
pkg/repl.go Updates replication logic to auto-detect and handle both JSON and HTML responses
.vscode/launch.json Adds VS Code debug configurations for development

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@krystian-panek-vmltech krystian-panek-vmltech merged commit e890c56 into main Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix replicate activate cmd

2 participants