This repository was archived by the owner on Oct 26, 2025. It is now read-only.
Conversation
…e husky as git hook manager
…Introduce TypeScript build system
…p and test the Telestion Client changes on a linked test project
…ic links on Windows which is not supported
…sions and direct packages to v17
pklaschka
suggested changes
Dec 31, 2022
Member
pklaschka
left a comment
pklaschka
left a comment
There was a problem hiding this comment.
Adding my original review back in (original source: #1467):
Great work overall. telestion-client-core should, however, stay clear of UI layer assumptions (such as React Spectrum, or ideally even web browsers as a platform in general).
Therefore, useSize() should move into telestion-client-common and the <SizeContext /> as a part of the <CommonWrapper />.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open PR in favor of fork PR for @jantischhoefer 😉
Details
n/a
Additional information
n/a
Related links
CLA