feat: ArgoCD chart improvements (hooks, HTTPRoute, image helper, .helmignore)#1
Merged
Merged
Conversation
…CD sync - Add httproute.enabled gate (default false) with HTTPRoute + ListenerSet templates. cert-manager auto-creates Certificates from ListenerSet annotations, replacing explicit Certificate CRDs. - Gate existing Ingress/Certificate/Middleware behind ingress.enabled (default true, backward-compatible). Projects migrate by setting ingress.enabled=false + httproute.enabled=true. - Add kindIs map guards to ingress range loops so the enabled boolean key doesn't break template iteration. - Add ArgoCD PreSync hook annotations to cleanup Job to prevent sync loop caused by ttlSecondsAfterFinished=0 self-deletion. - Add drupal.image helper for split repository/tag image values (ArgoCD Image Updater compatibility). - Update values.schema.json with httproute and ingress.enabled fields.
Traefik v3.7 doesn't support Gateway API ListenerSet (v1.5 feature). Switch HTTPRoute parentRef to reference the shared Gateway directly with sectionName. Use explicit Certificate CRDs for TLS instead of ListenerSet annotation-based auto-creation. Also adds listenerName value for configuring which Gateway listener the HTTPRoute attaches to.
Add chart.image helper to frontend and simple charts for ArgoCD
Image Updater compatibility. Supports both flat string images and
split {repository, tag} objects.
Port ingress.enabled gating from drupal chart to frontend and simple: - Wrap ingress, certificate, and middleware templates in ingress.enabled gate - Add kindIs 'map' guard to ingress range loops in checks.yaml - Add HTTPRoute template with Certificate CRDs for Gateway API - Add httproute values and schema (disabled by default) - ingress.enabled defaults to true (no breaking change)
The cleanup job uses volumes (PVCs) that don't exist during ArgoCD PreSync phase on first deploy. Add cleanup.enabled (default true for backward compat) and set false in platform base-values for ArgoCD clusters. Also use default SA for cleanup job since custom SA isn't available in PreSync.
…gnore - post-release.yaml: helm.sh/hook → argocd.argoproj.io/hook: PostSync - pre-release.yaml: helm.sh/hook → argocd.argoproj.io/hook: PreSync - .helmignore: exclude *.tgz and tests/ to keep chart size under 5MB - Bump version to 1.35.0
Remove Minikube deployment tests and silta CLI steps — argo-charts publishes to Harbor OCI for ArgoCD consumption, not deployed via silta CLI.
- Use curl-based Helm install instead of azure/setup-helm@v4 (may install wrong version) - Add ls of charts/ dir after dep build for debugging - Use helm template instead of helm install --dry-run (no cluster needed)
…tion Helm's .helmignore applies to all chart operations (template, lint, install), not just packaging. The *.tgz pattern was causing Helm to ignore subchart dependencies in charts/ directory, breaking template rendering. Keep only tests/ and test.values.yaml exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
These changes were accidentally pushed to wunderio/charts master and reverted (ed94f6c). This PR applies them to the correct repo (argo-charts) for Harbor OCI publishing.