Skip to content

Nginx-ingress removal from silta-cluster subcharts#496

Merged
Rade333 merged 2 commits into
release/2025-08-19from
feature/nginx-ingress-removal
Aug 19, 2025
Merged

Nginx-ingress removal from silta-cluster subcharts#496
Rade333 merged 2 commits into
release/2025-08-19from
feature/nginx-ingress-removal

Conversation

@Jancis
Copy link
Copy Markdown
Member

@Jancis Jancis commented Aug 18, 2025

We're referencing a fairly old nginx-ingress subchart (0.17.1). The referenced chart has become unavailable and yields test build errors. This change removes it from default installation set, suggests manual installation of the official chart.

Note: This applies to silta-cluster installations using Nginx Inc. ingress, only installations with nginx-ingress.enabled: true are affected. Installations with ingress-nginx.enabled: true are not affected by this removal. This change will also remove the related naming confusion :)

@Jancis Jancis requested a review from Rade333 August 18, 2025 07:53
@Rade333 Rade333 changed the base branch from master to release/2025-08-19 August 19, 2025 07:24
@Rade333 Rade333 merged commit 23bb786 into release/2025-08-19 Aug 19, 2025
12 of 13 checks passed
@Rade333 Rade333 deleted the feature/nginx-ingress-removal branch August 19, 2025 07:26
@Rade333 Rade333 mentioned this pull request Aug 19, 2025
@misterjoonas misterjoonas requested a review from Copilot August 21, 2025 05:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the nginx-ingress subchart dependency from silta-cluster to resolve build errors caused by the unavailable chart version (0.17.1), while providing migration guidance for existing users.

  • Removed nginx-ingress subchart from Chart.yaml dependencies and values.yaml configuration
  • Added comprehensive upgrade documentation with manual installation instructions
  • Updated README.md to remove nginx-ingress repository references and add upgrade path

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
silta-cluster/values.yaml Removes nginx-ingress configuration section (48 lines)
silta-cluster/docs/Upgrading-to-1.10.0.md Adds new upgrade guide with manual installation steps for nginx-ingress
silta-cluster/README.md Removes nginx-ingress repo setup and adds reference to upgrade documentation
silta-cluster/Chart.yaml Bumps version to 1.10.0 and removes nginx-ingress dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -0,0 +1,50 @@
# Upgrading silta-cluster chart to 1.10.0

This applies to silta-cluster installations using[ Nginx Inc. ingress](https://github.com/nginxinc/kubernetes-ingress/), only installations with `nginx-ingress.enabled: true` are affected. Installations with `ingress-nginx.enabled: true` are not affected by this removal, you don't have to do anything.
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space in the markdown link syntax. It should be using [Nginx Inc. ingress] instead of using[ Nginx Inc. ingress].

Suggested change
This applies to silta-cluster installations using[ Nginx Inc. ingress](https://github.com/nginxinc/kubernetes-ingress/), only installations with `nginx-ingress.enabled: true` are affected. Installations with `ingress-nginx.enabled: true` are not affected by this removal, you don't have to do anything.
This applies to silta-cluster installations using [Nginx Inc. ingress](https://github.com/nginxinc/kubernetes-ingress/), only installations with `nginx-ingress.enabled: true` are affected. Installations with `ingress-nginx.enabled: true` are not affected by this removal, you don't have to do anything.

Copilot uses AI. Check for mistakes.

## Nginx-ingress setup

Nginx Inc. [kubernete-ingress](https://github.com/nginxinc/kubernetes-ingress/) load balancer is removed from silta-cluster subchart list, but it is still compatible with ingresses and resources. If you want to keep using using it, you have to install the nginx-ingress manually.
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues in this line: 'kubernete-ingress' should be 'kubernetes-ingress', and there's a duplicate word 'using using' which should be just 'using'.

Suggested change
Nginx Inc. [kubernete-ingress](https://github.com/nginxinc/kubernetes-ingress/) load balancer is removed from silta-cluster subchart list, but it is still compatible with ingresses and resources. If you want to keep using using it, you have to install the nginx-ingress manually.
Nginx Inc. [kubernetes-ingress](https://github.com/nginxinc/kubernetes-ingress/) load balancer is removed from silta-cluster subchart list, but it is still compatible with ingresses and resources. If you want to keep using it, you have to install the nginx-ingress manually.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants