Add storage.silta/storage-path annotation to Solr's volumeClaimTemplates#503
Merged
Merged
Conversation
added 3 commits
September 15, 2025 13:37
…laimTemplates if storage class is either silta-shared or nfs-shared.
There was a problem hiding this comment.
Pull Request Overview
This PR adds the storage.silta/storage-path annotation to Solr's volumeClaimTemplates when specific storage classes are used to prevent data conflicts and loss. The change ensures that Solr data volumes are mapped to release-specific paths rather than namespace-level paths when using silta-shared or nfs-shared storage classes.
Key changes:
- Conditionally add storage path annotation for silta-shared and nfs-shared storage classes
- Remove duplicate accessModes property from volumeClaimTemplate
- Add comprehensive unit tests to verify annotation behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| drupal/templates/solr-statefulset.yaml | Added conditional annotation and fixed duplicate accessModes property |
| drupal/tests/solr_test.yaml | Added unit tests to verify storage path annotation behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Rade333
approved these changes
Sep 18, 2025
ArtisKrumins
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Solr allows to override the storageClassName in helm chart values but is missing the
storage.silta/storage-pathannotation. If storage class is overridden to silta-shared or nfs-shared, this will map Solr's data volume at{server_address}/{namespace-x}rather{server_address}/{namespace-x}/{release-x}/solr-data(i.e., similar to what shell’s volume would do:charts/drupal/templates/shell-volume.yaml
Line 41 in e6613fc
Mapping Solr's data volume to project's namespace folder can cause major issues on a project level, i.e.:
{server_address}/{namespace-x}folder from the server associated with the overridden storage class due to persistentVolumeReclaimPolicy: Delete set on the PV, causing major data loss.Changes proposed:
storage.silta/storage-pathannotation to Solr's volumeClaimTemplates if storage class is eithersilta-sharedornfs-shared, we can't add it by default as patching existing PVC's will fail.accessModesproperty fromvolumeClaimTemplateas unit tests were complaining about it.How to test: