Skip to content

Fix PATH override in syncdb command #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artisba wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PATH override in syncdb command #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commands/host/wunderio-core-syncdb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
## ExecRaw: true
## ProjectTypes: drupal9,drupal10,drupal11

export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:$HOME/.ddev/wunderio/core/
export PATH="$HOME/.ddev/wunderio/core/:$PATH"
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If $PATH is unset/empty in the environment, this expands to a trailing : (empty PATH entry), which implicitly adds the current working directory to PATH on many shells. Consider guarding for an empty/unset PATH (e.g., only append :$PATH when non-empty, or use ${PATH:+:$PATH}) to avoid accidentally including . in the executable search path.

Suggested change
export PATH="$HOME/.ddev/wunderio/core/:$PATH"
export PATH="$HOME/.ddev/wunderio/core/${PATH:+:$PATH}"

Copilot uses AI. Check for mistakes.

wdr-core.sh tooling syncdb.sh "$@"