Respect initialized receivers in constructors

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/validation/WurstValidator.java

@@ -1780,7 +1780,8 @@ private void checkField(NameRef access) {
                 if (!(field.getInitialExpr() instanceof NoExpr)
                     || (isCurrentInstanceAccess(access)
                         && writtenFields.contains(field))
-                    || (!(function instanceof ConstructorDef) && hasGuaranteedConstructorAssignment(field))
+                    || ((!isCurrentInstanceAccess(access) || !(function instanceof ConstructorDef))
+                        && hasGuaranteedConstructorAssignment(field))
                     || (delegatedConstructorCall != null && !access.isSubtreeOf(delegatedConstructorCall)
                         && hasGuaranteedConstructorAssignment(field))
                     || !warned.add(field)) {

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/ClassesTests.java

@@ -278,6 +278,27 @@ public void doesNotWarnForExplicitReceiverWithGuaranteedConstructorAssignment()
             result.getGui().getWarningList().toString());
     }
 
+    @Test
+    public void doesNotWarnForInitializedExplicitReceiverInsideConstructor() {
+        CompilationResult result = test()
+            .setStopOnFirstError(false)
+            .executeProg(false)
+            .lines(
+                "package Test",
+                "class Source",
+                "    int value",
+                "    construct()",
+                "        value = 1",
+                "class Holder",
+                "    construct(Source source)",
+                "        int copy = source.value"
+            );
+
+        assertFalse(result.getGui().getWarningList().stream()
+            .anyMatch(w -> w.getMessage().contains("no explicit initializer and is not definitely assigned")),
+            result.getGui().getWarningList().toString());
+    }
+
     @Test
     public void warnsForUninitializedFieldReadFromPackageFunction() {
         test()