Complete receiver-aware field read diagnostics

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/validation/WurstValidator.java

@@ -1760,8 +1760,7 @@ private void checkUninitializedVars(FunctionLike f) {
      * cheap, local check: it does not attempt interprocedural or path-sensitive reasoning.
      */
     private void checkPotentiallyUninitializedClassFields(FunctionLike function) {
-        ClassOrModule owner = function.attrNearestClassOrModule();
-        if (owner == null || function instanceof OnDestroyDef) {
+        if (function instanceof OnDestroyDef) {
             return;
         }
 
@@ -1779,7 +1778,7 @@ private void checkField(NameRef access) {
                     return;
                 }
                 if (!(field.getInitialExpr() instanceof NoExpr)
-                    || (!isInNestedClosure(access) && isCurrentInstanceAccess(access)
+                    || (isCurrentInstanceAccess(access)
                         && writtenFields.contains(field))
                     || (!(function instanceof ConstructorDef) && hasGuaranteedConstructorAssignment(field))
                     || (delegatedConstructorCall != null && !access.isSubtreeOf(delegatedConstructorCall)

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/ClassesTests.java

@@ -278,6 +278,43 @@ public void doesNotWarnForExplicitReceiverWithGuaranteedConstructorAssignment()
             result.getGui().getWarningList().toString());
     }
 
+    @Test
+    public void warnsForUninitializedFieldReadFromPackageFunction() {
+        test()
+            .setStopOnFirstError(false)
+            .executeProg(false)
+            .expectWarning("no explicit initializer and is not definitely assigned")
+            .lines(
+                "package Test",
+                "class Counter",
+                "    int value",
+                "function read(Counter counter) returns int",
+                "    return counter.value"
+            );
+    }
+
+    @Test
+    public void doesNotWarnForClosureReadAfterPriorAssignment() {
+        CompilationResult result = test()
+            .setStopOnFirstError(false)
+            .executeProg(false)
+            .lines(
+                "package Test",
+                "interface Reader",
+                "    function read() returns int",
+                "function consume(Reader reader)",
+                "class Counter",
+                "    int value",
+                "    construct()",
+                "        value = 1",
+                "        consume(() -> value)"
+            );
+
+        assertFalse(result.getGui().getWarningList().stream()
+            .anyMatch(w -> w.getMessage().contains("no explicit initializer and is not definitely assigned")),
+            result.getGui().getWarningList().toString());
+    }
+
     @Test
     public void classes1() throws IOException {
         testAssertOkFile(new File(TEST_DIR + "Classes_1.wurst"), true);