Inline monomorphic methods in optimized Lua - #1296
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
CI exposed broad optimized-output shape churn outside hot loops. I restricted the lowering to monomorphic calls structurally inside IM loops; the full LuaTranslationTests class (114 tests) and the focused Lua backend matrix now pass locally. @codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Acceptance criteria
Checks
LuaBackendAuditTestsmatrix covering the new behavior, Jass/Lua receiver parity, callback and local-player barriers, fixed and dynamic varargs, virtual dispatch, and UnitSpatialIndex emitted shapeLuaTranslationTestsclass (114 tests)git diff --checkReview
4da675e9dcwith no inline findings or unresolved threads.