Skip to content

Pull Request for Wave Software Development Challenge - Mobile Engineer by Binoli Mhatre #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binoliMhatre wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pull Request for Wave Software Development Challenge - Mobile Engineer by Binoli Mhatre #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a752df
Solution to Wave Technical Challenge by Binoli Mhatre
binoliMhatre Mar 21, 2019
683e1ed
Formatting
binoliMhatre Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 15 additions & 36 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,26 @@
# Wave Software Development Challenge
Applicants for the [Mobile engineer](https://wave.bamboohr.co.uk/jobs/view.php?id=6) role at Wave must complete the following challenge, and submit a solution prior to the onsite interview.

The purpose of this exercise is to create something that we can work on together during the onsite. We do this so that you get a chance to collaborate with Wavers during the interview in a situation where you know something better than us (it's your code, after all!)

There isn't a hard deadline for this exercise; take as long as you need to complete it. However, in terms of total time spent actively working on the challenge, we ask that you not spend more than a few hours, as we value your time and are happy to leave things open to discussion in the onsite interview.
# App Implementation details:

You can write your app using your favorite language, tools, platform, etc. Whether that means something native or something hybrid is completely up to you.
1. The App supports iPhone Portrait mode only

Send your submission to [dev.careers@waveapps.com](dev.careers@waveapps.com). Feel free to email [dev.careers@waveapps.com](dev.careers@waveapps.com) if you have any questions.
2. The App supports different screen sizes of iPhone

## Submission Instructions
1. Fork this project on github. You will need to create an account if you don't already have one.
1. Complete the project as described below within your fork.
1. Push all of your changes to your fork on github and submit a pull request.
1. You should also email [dev.careers@waveapps.com](dev.careers@waveapps.com) and your recruiter to let them know you have submitted a solution. Make sure to include your github username in your email (so we can match applicants with pull requests.)
3. The App requires internet connection to retrieve products

## Alternate Submission Instructions (if you don't want to publicize completing the challenge)
1. Clone the repository.
1. Complete your project as described below within your local repository.
1. Email a patch file to [dev.careers@waveapps.com](dev.careers@waveapps.com).
4. While the app is checking for the internet connection and loading products, you can see activity indicator to indicate that a task is in progress

## Project Description
In this project, we're going to be creating a simple app that shows a Wave user the products that they can charge for on their invoices.
5. In case there is no Internet connection, the app displays the status saying "Internet Not Available!” so the user is aware what exactly the problem is.

You'll be using the public Wave API in this challenge. You can find the documentation [here](http://docs.waveapps.io/). You will specifically be interested in [the products endpoint](http://docs.waveapps.io/endpoints/products.html#get--businesses-business_id-products-), and [using an access token with the API](http://docs.waveapps.io/oauth/index.html#use-the-access-token-to-access-the-api).
6. If the web service is down or unreachable, the app displays the status saying "Could not retrieve products!" so the user is aware of whats wrong.
7. I’ve implemented the custom table view cell that enables displaying the products in neat organized manner and can be used to display additional information if required without getting into the detail view.
8. I’ve defined the constants in the code for the important URLS and the dictionary keys so as to reduce the risk of alteration.
9. The code is well commented and has pragma marks to divide code into logical sections thus making it easy to read through the code and also adding visual cues to Xcode source navigator.
10. The App supports iOS version 9.3 or greater

Your Wave contact will supply you with a business ID and a Wave API token before you begin.
# How to run the project:

### What your application must do:

1. Your app must retrieve the list of products for the specific business ID sent to you by your Wave contact
1. The list of products should be fetched and shown to the user in a list view when the app is launched.
1. Each item in the list view should show the product name and price (formatted as a dollar amount.)

You are not required to add any interactivity to the app -- i.e. you do not need to send the user to a detail view when they touch one of the list items.

Your app is allowed to render nothing if there is no internet connection when it loads.

Once you're done, please submit a paragraph or two in your `README` about what you are particularly proud of in your implementation, and why.

## Evaluation
Evaluation of your submission will be based on the following criteria.

1. Did your application fulfill the basic requirements?
1. Did you document the method for setting up and running your application?
1. Did you follow the instructions for submission?
1. Open the “Wave Technical Challege.xcodeproj” file using Xcode
2. Run the project by selecting the iPhone simulator having iOS version 9.3 or greater
3. Provided you have internet connection, the App will run and you can see the products and their prices else it will display status message saying "Internet Not Available!”
Loading