Open
Conversation
- added gitignore - created project - dropped in some basic pods we will need
- Removed `Apollo` since we are using REST instead of GraphQL - Added `Moya` in preparation for networking - Modified scheme to only run unit-tests - Added file loader to load data from fixtures - Added unit tests for `Product` and `[Product]` parsing
- Added API definition - Dropped in `SwiftLint` & lnting run-script - Dropped in `SwiftyBeaver` for logging
- Moved log setup to its own file - Switched to programmatically loading injected app-view-controller on launch - Created UI-factories to instantiate view-controllers & perform property injection - Built basic app-coordinator & view-controller to switch between flows based on state - Created skeletons of product-list UI - Added utility extensions for Rx & UIKit for readability - Added `force_unwrapping` swiftlint rule - Added custom rule to limit injection access
- Defined `ProductsDataServicing` protocol to facade `DataService` and make unit testing easier later - Built fetch-products request, parsing, and update of in-memory cache - Built mock for various scenarios of data-fetching using the `ProductsAPI` - Fixed up access modifier inconsistencies
- Map to items from `Product` data type - Wired up `DataService` to `ProductDataServicing` - Built refresh mechanism in view-model
- Added some logs - Added a refresh control - Draw cells & refresh list
- Created Networking factory for standard instantiation of networking classes - Added `Providable` protocol - Dropped in postman collection
- Communicating language preferences to server side done via headers (last commit)
- Walkthrough of TODO's warnings - Changed `APIKeys` to `AppSecrets` - Added swift-lint rule to guard against `UIKit` imports - Initial mind-dump into `README`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.