Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 2, 2025

  • Analyze current HTML and SVG tags/attributes structure
  • Identify naming conflicts between HTML and SVG attributes and tags
  • Design solution for resolving naming conflicts
  • Implement solution allowing import wvlet.airframe.rx.html.all.* to work with both HTML and SVG
  • Create tests to validate the solution
  • Verify backward compatibility

Identified Conflicts:

  • Attribute conflicts: class, type, height, id, max, min, style, width, xmlns
  • Tag conflicts: title (HTML tag in HtmlTagsExtra vs SVG tag in HtmlSvgTags)

Solution Plan:
Will implement approach 2 (non-conflict naming) by:

  1. Creating prefixed versions of conflicting SVG attributes/tags (e.g., svgStyle, svgTitle)
  2. Extending the all object to include both HTML and SVG without conflicts
  3. Maintaining backward compatibility with existing svgTags and svgAttrs objects

Fixes #3953.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rx-html: Resolve naming conflicts between HTML and SVG attributes, e.g., style, title

2 participants