Skip to content

Conversation

@xerial-bot
Copy link
Collaborator

About this PR

📦 Updates com.google.protobuf:protobuf-java from 3.25.8 to 4.33.3

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.protobuf", artifactId = "protobuf-java" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.protobuf", artifactId = "protobuf-java" }
}]
labels: library-update

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the update of the protobuf-java dependency to its latest stable version, 4.33.3. This update ensures the project benefits from the latest features, performance enhancements, and security fixes provided by the Protocol Buffers library, maintaining compatibility and leveraging improvements in data serialization.

Highlights

  • Dependency Update: The protobuf-java library has been updated from version 3.25.8 to 4.33.3.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to update com.google.protobuf:protobuf-java from 3.25.8 to 4.33.3. This is a major version upgrade and has a few issues. First, version 4.33.3 of protobuf-java does not exist in Maven Central, which will cause the build to fail. The latest version at this time is 4.27.2. Second, a major version upgrade of protobuf-java from 3.x to 4.x will likely require regenerating the protobuf-based Java source files in the airframe-benchmark module. These files appear to be checked into the repository and were generated with an old version of the gRPC proto compiler. Without regenerating them, the build is likely to fail due to API incompatibilities.

// For grpc-java
"io.grpc" % "grpc-protobuf" % GRPC_VERSION,
"com.google.protobuf" % "protobuf-java" % "3.25.8",
"com.google.protobuf" % "protobuf-java" % "4.33.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version 4.33.3 for com.google.protobuf:protobuf-java does not appear to exist in Maven Central. This will cause the dependency resolution to fail. Please use a valid version. The latest version is 4.27.2 as of the time of this review. Note that this is a major version upgrade and may require other code changes, such as regenerating protobuf sources.

        "com.google.protobuf" % "protobuf-java" % "4.27.2",

@xerial-bot
Copy link
Collaborator Author

Superseded by #4144.

@xerial-bot xerial-bot closed this Jan 12, 2026
@xerial-bot xerial-bot deleted the update/protobuf-java-4.33.3 branch January 12, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants