-
Notifications
You must be signed in to change notification settings - Fork 69
Update protobuf-java to 4.33.3 #4141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request attempts to update com.google.protobuf:protobuf-java from 3.25.8 to 4.33.3. This is a major version upgrade and has a few issues. First, version 4.33.3 of protobuf-java does not exist in Maven Central, which will cause the build to fail. The latest version at this time is 4.27.2. Second, a major version upgrade of protobuf-java from 3.x to 4.x will likely require regenerating the protobuf-based Java source files in the airframe-benchmark module. These files appear to be checked into the repository and were generated with an old version of the gRPC proto compiler. Without regenerating them, the build is likely to fail due to API incompatibilities.
| // For grpc-java | ||
| "io.grpc" % "grpc-protobuf" % GRPC_VERSION, | ||
| "com.google.protobuf" % "protobuf-java" % "3.25.8", | ||
| "com.google.protobuf" % "protobuf-java" % "4.33.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version 4.33.3 for com.google.protobuf:protobuf-java does not appear to exist in Maven Central. This will cause the dependency resolution to fail. Please use a valid version. The latest version is 4.27.2 as of the time of this review. Note that this is a major version upgrade and may require other code changes, such as regenerating protobuf sources.
"com.google.protobuf" % "protobuf-java" % "4.27.2",
|
Superseded by #4144. |
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.8to4.33.3⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: