-
Notifications
You must be signed in to change notification settings - Fork 69
Update airframe-http, airframe-http-netty, ... to 2025.1.27 #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the airframe dependency to version 2025.1.27 across several example projects. The changes are straightforward version bumps. I've added one suggestion to centralize the version definition for these example projects to improve maintainability for future updates.
| @@ -1,4 +1,4 @@ | |||
| val AIRFRAME_VERSION = "2025.1.26" | |||
| val AIRFRAME_VERSION = "2025.1.27" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and avoid inconsistencies, I suggest centralizing the AIRFRAME_VERSION. This version string is duplicated in several example build.sbt files, and also in project/plugins.sbt files.
A common practice in sbt projects is to define versions in a single place. For example, you could create a project/Versions.scala file:
object Versions {
val airframe = "2025.1.27"
}Then, you can reference this value in your build files:
- In
build.sbt:val AIRFRAME_VERSION = Versions.airframe - In
project/plugins.sbt:addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % Versions.airframe)
This change would make future dependency updates much easier to manage by only requiring a change in one file.
About this PR
📦 Updates
from
2025.1.26to2025.1.27📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: