Skip to content

Conversation

@xerial-bot
Copy link
Collaborator

About this PR

📦 Updates

from 1.16.0 to 1.17.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (1.16.0).
You might want to review and update them manually.

docs/release-notes.md
examples/rx-demo/gallery/src/main/public/index.html
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.apache.parquet" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.parquet" }
}]
labels: library-update

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine but important dependency upgrade, specifically updating the Apache Parquet libraries (parquet-avro and parquet-hadoop) to their latest stable release, version 1.17.0. This update ensures the project benefits from the most recent enhancements, bug fixes, and performance optimizations provided by the Parquet project, maintaining compatibility and leveraging modern data handling capabilities.

Highlights

  • Dependency Update: Upgraded org.apache.parquet:parquet-avro and org.apache.parquet:parquet-hadoop from version 1.16.0 to 1.17.0.
  • Build Configuration: The PARQUET_VERSION constant in build.sbt has been updated to reflect the new dependency version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates org.apache.parquet:parquet-avro and org.apache.parquet:parquet-hadoop to version 1.17.0. While this is a standard dependency update, it carries a notable risk for the airframe-parquet module, which employs a delicate, hadoop-free configuration that is sensitive to changes in parquet-hadoop. A thorough validation through the project's test suite is essential to prevent potential runtime failures. Additionally, as pointed out in the PR description, there are files that still reference the old version number and may require manual updates.

val JMH_VERSION = "1.37"
val JAVAX_ANNOTATION_API_VERSION = "1.3.2"
val PARQUET_VERSION = "1.16.0"
val PARQUET_VERSION = "1.17.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating PARQUET_VERSION to 1.17.0 introduces a significant risk for the airframe-parquet module. This module's hadoop-free feature relies on a fragile dependency configuration for parquet-hadoop, as documented in this file (lines 1012-1018). This new version could have different transitive dependencies on Hadoop, potentially causing NoClassDefFoundError at runtime because the explicit dependency list might be outdated. This fragility makes this version bump a high-risk change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants