Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ lazy val fluentd =
// td-client-java -> json-simple happened to include junit 4.10 [CVE-2020-15250]
exclude ("junit", "junit"),
// Necessary for td-client-java, which is used in fluency-treasuredata
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.18.5" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.21.0" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.18.5" % Provided,
Comment on lines +978 to 979
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It is a best practice to keep versions of related libraries, especially from the same group like Jackson, aligned. While jackson-datatype-json-org is updated, jackson-datatype-jdk8 is still on version 2.18.5. Mixing versions can lead to binary incompatibility issues at runtime. Please update jackson-datatype-jdk8 to 2.21.0 as well.

        "com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.21.0" % Provided,
        "com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8"     % "2.21.0" % Provided,

// Redirecting slf4j log from Fluency to aiframe-log
"org.slf4j" % "slf4j-jdk14" % SLF4J_VERSION
Expand Down
Loading