Major speedups and bug fixes to CustomTreeCtrl and HyperTreeList #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wxWidgets#2083, wxWidgets#2081, wxWidgets#1981, wxWidgets#1938, wxWidgets#1901, wxWidgets#1898, wxWidgets#1880, wxWidgets#1293 Runs 10-100x faster while using slightly more memory. Adds a new style `TR_LIVE_UPDATE` to show column resizing live rather than drawing a preview line. Bump version from 1.4 to 1.5
swt2c
reviewed
Jan 24, 2022
wx/lib/agw/customtreectrl.py
Outdated
| memory.DrawLabel(self._text, textrect) | ||
|
|
||
| memory.SelectObject(wx.NullBitmap) | ||
|
|
||
| # Gtk and Windows unfortunately don't do so well with transparent | ||
| # Gtk and Windows unfortunatly don't do so well with transparent |
There was a problem hiding this comment.
It seems like you overwrote a bunch of spelling fixes that were made.
|
This pull request has been mentioned on Discuss wxPython. There might be relevant details there: |
swt2c
reviewed
Apr 18, 2025
wx/lib/agw/customtreectrl.py
Outdated
| .. versionadded:: 2.8 | ||
| """ | ||
| if not isinstance(text, six.text_type): | ||
| if isinstance(text, six.binary_type): |
There was a problem hiding this comment.
Can you please remove uses of six? We've removed six as a dependency.
There was a problem hiding this comment.
@swt2c Are you going to consider this PR, or my replacement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve speed of controls especially with a large number of items. Up to 10 - 100x speedup. Issues were:
CustomTreeCtrl version bump from 2.7 to 2.8
HyperTreeList version bump from 1.4 to 1.5
Fixes #2006
Fixes #1938
Fixes #1395
Fixes #2083
Fixes #2081
Fixes #1981
Fixes #1938
Fixes #1901
Fixes #1898
Fixes #1880
Fixes #1293