Fix zerodivision errors in pdfviewer when windows are extremely small #2465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error:
which can be observed by trying to resize a window containing a
pdfviewer
to extremely small sizes.I remark that this PR expands on a previous PR of mine a few years ago, which handled the case when window client sizes were exactly zero on initialization #1519 but did not consider cases where window client sizes were very small, which would, through rounding from floating point to int, also result in ZeroDivision errors as shown above.