Skip to content

fix: recreating keyboardShortcuts interface on file changes. #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix: recreating keyboardShortcuts interface on file changes. #1465

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5eefbfd
fix: restarting keyboardShortcuts listener on file changes.
nishu-murmu Feb 28, 2025
f522341
Merge branch 'main' of github.com:wxt-dev/wxt into keyboardshortcut-o…
nishu-murmu Mar 4, 2025
d077bb0
fix: closing the listeners instead of the interface
nishu-murmu Mar 4, 2025
18b15c1
Merge branch 'main' of github.com:wxt-dev/wxt into keyboardshortcut-o…
nishu-murmu Mar 24, 2025
408ff24
fix: returning createFileReloader function and adding null checks.
nishu-murmu Mar 24, 2025
417676f
chore: remove if statement.
nishu-murmu Mar 24, 2025
1f45727
Merge branch 'main' of github.com:wxt-dev/wxt into keyboardshortcut-o…
nishu-murmu Mar 31, 2025
f8b27ac
Merge branch 'main' of github.com:wxt-dev/wxt into keyboardshortcut-o…
nishu-murmu Apr 10, 2025
e2cb479
Merge branch 'keyboardshortcut-onchange' of github.com:nishu-murmu/wx…
nishu-murmu Apr 10, 2025
286677a
Merge branch 'main' of github.com:wxt-dev/wxt into keyboardshortcut-o…
nishu-murmu Apr 10, 2025
c952a42
Merge branch 'keyboardshortcut-onchange' of github.com:nishu-murmu/wx…
nishu-murmu Apr 10, 2025
2ee680c
fix: updating reloadOnChange function.
nishu-murmu Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/wxt/src/core/create-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,15 @@ async function createServerInternal(): Promise<WxtDevServer> {
await buildAndOpenBrowser();

// Listen for file changes and reload different parts of the extension accordingly
const reloadOnChange = createFileReloader(server);
const reloadOnChange = () => {
createFileReloader(server);
keyboardShortcuts.start();
keyboardShortcuts.printHelp({
canReopenBrowser:
!wxt.config.runnerConfig.config.disabled && !!runner.canOpen?.(),
});
};
server.watcher.on('all', reloadOnChange);
keyboardShortcuts.start();
keyboardShortcuts.printHelp({
canReopenBrowser:
!wxt.config.runnerConfig.config.disabled && !!runner.canOpen?.(),
});
},

async stop() {
Expand Down
10 changes: 7 additions & 3 deletions packages/wxt/src/core/keyboard-shortcuts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ export function createKeyboardShortcuts(

return {
start() {
if (rl) return;
if (rl) {
rl.on('line', handleInput);
return;
}

rl = readline.createInterface({
input: process.stdin,
Expand All @@ -37,8 +40,9 @@ export function createKeyboardShortcuts(
},

stop() {
rl?.close();
rl = undefined;
if (rl) {
rl.removeListener('line', handleInput);
}
},

printHelp(flags) {
Expand Down