Skip to content

fix: adding missing "" to PublicPath and browser.runtime.getUrl. #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

nishu-murmu
Copy link
Contributor

Overview

for public path "" was missing
basically browser.runtime.getUrl("") command is throwing type error.
I guess something was updated in this function getPathsDeclarationEntry which broke that.
when running pnpm compile it also throws error.

Manual Testing

  1. add browser.runtime.getUrl("") in background.ts file (you'll see the type error).
  2. additionally try running this command pnpm compile

Copy link

netlify bot commented Apr 20, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 265dcf5
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6805d46c95f9340008e70932
😎 Deploy Preview https://deploy-preview-1597--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it go first? I purposefully put "/" first so IDEs show it at the top. "" should probably go above it?

@nishu-murmu
Copy link
Contributor Author

Should it go first? I purposefully put "/" first so IDEs show it at the top. "" should probably go above it?

@aklinker1 Updated.

Copy link

pkg-pr-new bot commented Apr 21, 2025

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1597

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1597

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1597

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1597

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1597

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1597

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1597

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1597

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1597

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1597

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1597

wxt

npm i https://pkg.pr.new/wxt@1597

commit: 265dcf5

@aklinker1 aklinker1 merged commit a6c4e19 into wxt-dev:main Apr 24, 2025
16 checks passed
Copy link
Contributor

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants