-
-
Notifications
You must be signed in to change notification settings - Fork 294
fix: adding missing "" to PublicPath and browser.runtime.getUrl. #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it go first? I purposefully put "/"
first so IDEs show it at the top. ""
should probably go above it?
@aklinker1 Updated. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Thanks for helping make WXT better! |
Overview
for public path
""
was missingbasically
browser.runtime.getUrl("")
command is throwing type error.I guess something was updated in this function
getPathsDeclarationEntry
which broke that.when running
pnpm compile
it also throws error.Manual Testing
browser.runtime.getUrl("")
in background.ts file (you'll see the type error).pnpm compile