-
-
Notifications
You must be signed in to change notification settings - Fork 302
chore: Use Bun for package management #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
@@ -6,6 +6,7 @@ | |||
# Mark lock files as generated to avoid diffing | |||
pnpm-lock.yaml linguist-generated | |||
package-lock.json linguist-generated | |||
bun.lock linguist-generated | |||
bun.lockb linguist-generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bun.lockb linguist-generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a test fixture containing a binary lockfile, I'll try and remove this one when I update E2E tests to use bun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a test fixture containing a binary lockfile, I'll try and remove this one when I update E2E tests to use bun.
Okay
bun run build | ||
bun publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using npm
instead in this case, because Bun does not yet support the --provenance
flag for signing releases (see oven-sh/bun#15601)
bun run build | |
bun publish | |
bunx npm set "//registry.npmjs.org/:_authToken=${{ secrets.NPM_AUTH_TOKEN }}" | |
bunx npm publish --provenance --access public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WXT doesn't have provenance right now, so I'll do this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WXT doesn't have provenance right now, so I'll do this in a separate PR.
Ok
After merging this PR, we can then migrate all It's not urgent, everything is drop-in replacement there except mocks, in Bun it's a bit specific |
Co-authored-by: Okinea Dev <[email protected]>
Yeah, if we decide to migrate tests, we'll do that in a separate PR. |
Please add |
Errors in tests due to lack of pnpm? It seems that Node.js and pnpm should be added to the test workflows |
Yeah, boarding a plane rn and traveling all day today, so this will have to wait until tomorrow. |
This closes #1643.