fix(ci): drop Node 18.x from the test matrix (EOL, vitest 4 requires 20.12+)#39
Open
asachs01 wants to merge 1 commit into
Open
fix(ci): drop Node 18.x from the test matrix (EOL, vitest 4 requires 20.12+)#39asachs01 wants to merge 1 commit into
asachs01 wants to merge 1 commit into
Conversation
…20.12+) vitest 4.x imports styleText from node:util, added in Node 20.12 - the Node 18.x job fails at Vitest startup with a SyntaxError before any test runs, unrelated to the actual code. Node 18 is EOL per the orgs 2026-07-18 EOL-Node audit (wyre-technology/.github PR 35), so dropping it from the matrix rather than trying to keep vitest working on it. Also fixed the stale engines.node (was >=18.0.0, now >=20.0.0) to match the real runtime requirement. Verified locally: lint/test/build all clean on Node v26.4.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 18.x CI job fails at Vitest startup - vitest 4.x imports
styleTextfromnode:util, added in Node 20.12+. Not a code bug, a matrix gap: Node 18 is EOL per the orgs 2026-07-18 EOL-Node audit (wyre-technology/.github PR #35). Drops 18.x from the matrix, fixes the staleengines.node(was >=18.0.0, now >=20.0.0).Verified locally: lint/test/build all clean. Letting CI confirm on 20.x/22.x before merge.