Fix CMake policy version compatibility issue with GoogleTest dependencies - #13
Merged
Merged
Conversation
Set CMAKE_POLICY_VERSION_MINIMUM=3.5 when not already defined to prevent CMake compatibility errors when fetching GoogleTest dependencies. This resolves the build failure that occurs with newer CMake versions. Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] 你的任务: 解决流水线里面 cmake 编译的报错问题。
描述:我的任务设置了 github workflow, 运行时有下面的报错:
```
-- ccap: Using bundled GLFW
-- ccap: GLFW available: ON
-- ccap: Add example: 0-print_camera
-- ccap...
Fix CMake policy version compatibility issue with GoogleTest dependencies
Sep 23, 2025
wysaid
marked this pull request as ready for review
September 23, 2025 12:39
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CMake compatibility issues with newer CMake versions (3.31+) when building with GoogleTest dependencies by setting a minimum policy version.
- Adds conditional CMAKE_POLICY_VERSION_MINIMUM setting to avoid compatibility errors
- Preserves backward compatibility and existing user configurations
- Resolves CI/CD pipeline failures when building with tests enabled
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub Actions workflows were failing with CMake compilation errors when building with tests enabled:
This error occurs when newer CMake versions (3.31+) encounter older dependency projects like GoogleTest that specify very old minimum required versions that are no longer supported.
Solution
Added a conditional setting of
CMAKE_POLICY_VERSION_MINIMUMto the main CMakeLists.txt:Key Features
run_tests.shthat already set this parameter continue to work unchangedTesting
Verified the fix works across multiple scenarios:
Impact
This resolves the CI/CD pipeline failures and ensures that GitHub Actions workflows can build the project with tests enabled without requiring manual parameter configuration. Local development workflows remain unchanged.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.