Allow setting custom licence HTML in footer #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for govuk-components pending review.Visit the deploys page to approve it
|
|
Very sensible! Thanks - looks great 🙂 |
|
Thanks @peteryates! I've tried adding instructions for using this to the guide, but I'm not familiar with Slim so maybe it could be improved |
|
The guide is out of action at the moment anyway because of #591 😞 Just taking a look at this. |
peteryates
approved these changes
May 15, 2025
|
@peteryates is this good to be merged? |
|
Yep, feel free 🙂 |
|
I don't think I have the ability to merge |
There is already an attribute to set custom licence text, however this does not allow including links or a logo, meaning it's not possible to internatialise the footer without removing these items. Allow passing in `licence_meta_html` as a block to be included instead of the default licence content.
peteryates
force-pushed
the
allow-passing-in-licence-html-to-footer
branch
from
38b7529 to
96cceed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already an attribute to set custom licence text, however this does not allow including links or a logo, meaning it's not possible to internatialise the footer without removing these items.
Allow passing in
licence_meta_htmlas a block to be included instead of the default licence content.If this change seems sensible, I can attempt to update the documentation.