Make hardcoded text translatable #561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-form-builder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The date input has hardcoded label text for day, month and year. They should be overrideable and translatable. This change adds a new param called segment_names that follows the format of the segments arg. Passing :day, :month and :year values will allow the labels to be customised. The segment names are also configurable using the default_date_segment_names config option. Refs #558
peteryates
force-pushed
the
make-hardcoded-text-translatable
branch
from
2ffabdb to
b71a9f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some bits of text in the library that are hardcoded and there's no ability to override/configure them.
This PR intends to fix them which will make it easier to use the library in non-English or multilingual applications.