Support injecting content before and after inputs #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These arguments allow content, either text or HTML (via a proc) to be inserted before and after inputs. The naming of the arguments follows the GOV.UK Design System - which isn't ideal as: * the argument names are plural for dates (before_inputs, after_inputs), because there are multiple inputs * select doesn't have an input element, so the name isn't consistent Refs #478
✅ Deploy Preview for govuk-form-builder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design system has supported
before_inputandafter_inputparams for some time.They place the provided content before and after the input (or group of inputs, select, etc) within a form component.
Unlike in the Nunjucks macros, here the arguments are placed on the form builder methods directly, rather than within the form group. It makes them easier to document and in this library the form group object only really is responsible for attributes on the form group element, rather than any actual rendering.
Fixes #478