Skip to content

Commit 3dca8f1

Browse files
nickspmarlovralternate-marlopiotrpasich
authored
"Version-5.5.0" release (#549)
* Fix non-existing avatar loading (#536) * [CLEANUP] Auto build XP UI upon installing a package (#532) * Remove lib/ files from the repo * Remove redundant zappr config * Limit the scope of installed package * Remove useless on push build * Add `data-testid` attribute to job related components (#539) Why: * This attribute is required for the Cypress tests in `xp-registration` Co-authored-by: Marlo Vinall Richardson <[email protected]> * [CLEANUP] Revert changes to keep xp-ui lib files in a repo * Remove Contact UI and Email History code (#544) * Debug code * XP-3677 Remove Contact UI and Email History code Co-authored-by: Nick Plekhanov <[email protected]> * Add attribute hooks to job related components (#540) * Add missing `data-testid` attribute to Modal Why: * A test in `xp-registration` XP-3623 fails without this attribute * Correct `data-testid` attributes Why: * Established naming convention dictates that camel case should be used * Build the app Co-authored-by: Marlo Vinall Richardson <[email protected]> Co-authored-by: Nick Plekhanov <[email protected]> Co-authored-by: Marlo <[email protected]> Co-authored-by: Marlo Vinall Richardson <[email protected]> Co-authored-by: Piotr Pasich <[email protected]>
1 parent 2c23d46 commit 3dca8f1

31 files changed

+47
-950
lines changed

.zappr.yaml

-30
This file was deleted.

lib/.babelrc

-1
This file was deleted.

lib/.eslintrc

Whitespace-only changes.
-11.4 KB
Binary file not shown.
-47.3 KB
Binary file not shown.

lib/all.js

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/all.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/editor.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/editor.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/fonts.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/fonts.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/registration.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/registration.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
"version": "2.0.0",
44
"description": "UI component library for the XP platform.",
55
"main": "lib/all.js",
6+
"files": [
7+
"lib"
8+
],
69
"directories": {
710
"doc": "docs"
811
},

src/components/ui/AccountConfirmation.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class AccountConfirmation extends PureComponent<Props, void> {
115115
{(avatar || fullName) && (
116116
<span className={cx.avatar}>
117117
<Avatar
118-
src={avatar || fullName}
118+
src={avatar}
119119
alt={fullName}
120120
size={80}
121121
/>

src/components/ui/AccountConfirmation.stories.js

+9
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,15 @@ storiesOf('UI Components|AccountConfirmation', module)
3232
))
3333

3434
storiesOf('UI Components|AccountConfirmation/Debug', module)
35+
.add('avatar src is not passed in', () => (
36+
<AccountConfirmation
37+
fullName='Monica Blacksmith'
38+
39+
onContinue={action('onContinue')}
40+
onSignOut={action('onSignOut')}
41+
/>
42+
))
43+
3544
.add('missing props', () => (
3645
<AccountConfirmation />
3746
))

src/components/ui/ApplicantScreenNotification.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class ApplicantScreenNotification extends PureComponent<Props, State> {
189189
exit: EXIT_TIMEOUT
190190
}}
191191
>
192-
<div className={[cx.container, cx.color[this.props.type]].join(' ')}>
192+
<div className={[cx.container, cx.color[this.props.type]].join(' ')} data-testid='xpui-applicantScreenNotification'>
193193
<div className={cx.content}>
194194
{this.renderIcon()}
195195
<div className={cx.text}>

src/components/ui/Avatar.stories.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ storiesOf('Core Components|Avatar/Use Cases', module)
3838
))
3939

4040
storiesOf('Core Components|Avatar/Debug', module)
41-
.add('missing props (does component explode?)', () => (
42-
<Avatar />
43-
))
4441
.add('with not reachable image source', () => (
4542
<Avatar
4643
src='https://x-team.com/some-path-that-doesn-exists.png'
4744
alt='X P'
4845
size={32}
4946
/>
5047
))
48+
.add('missing props', () => (
49+
<Avatar />
50+
))

src/components/ui/Email.js

-181
This file was deleted.

0 commit comments

Comments
 (0)