Ws reconnect#33
Open
Fogapod wants to merge 7 commits into
Open
Conversation
x86y
reviewed
May 10, 2024
| web-sys = { version = "0.3", features = ["Window", "Storage"] } | ||
|
|
||
| [patch.crates-io] | ||
| binance-rs-async = { git = "https://github.com/Fogapod/binance-rs-async", rev = "fb2a1daf1063d3b7edb551d4dc8ef8d4d7197538" } |
Contributor
Author
There was a problem hiding this comment.
it removes a few dependencies from that lib
x86y
force-pushed
the
master
branch
12 times, most recently
from
2705541 to
d9709a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a replacement for
event_loopfrom binance lib that responds to pings and sends pings.If Pong was not seen in
PING_INTEVAL * 2(10 seconds), ws will switch to disconnected state.Resolves: #30
This includes #32 but its likely not needed since changes are outside the lib