Skip to content

Conversation

@tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Sep 25, 2024

Description

Summary of Changes

  • Update changelog
  • Make sure conda envs are up to do date
  • Remove deprecated bool arg in docstrings of dataset.py
  • Add SciPy 2024 youtube link to docs
  • Fix NumFocus logo link in SciPy notebook

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9e73dd) to head (61fae85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #700   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1546      1546           
=========================================
  Hits          1546      1546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomvothecoder
Copy link
Collaborator Author

Hey @lee1043, can you checkout the latest main and run a test on PMP for PR #689? The results should still be the same as before.

Once this is done, I can proceed with releasing v0.7.2 in the next week or two.

@tomvothecoder tomvothecoder marked this pull request as ready for review September 26, 2024 20:35
@tomvothecoder
Copy link
Collaborator Author

I actually don't think we need to do extensive testing for #689 because the unit tests pass and my test case works as expected. I am moving forward with this PR.

@tomvothecoder tomvothecoder changed the title Bump to 0.7.2 Bump to v0.7.2 Oct 2, 2024
@github-actions github-actions bot added the type: docs Updates to documentation label Oct 2, 2024
@tomvothecoder tomvothecoder merged commit f9d1566 into main Oct 2, 2024
10 checks passed
@tomvothecoder tomvothecoder deleted the bump/v0.7.2 branch October 2, 2024 18:43
@tomvothecoder tomvothecoder self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: docs Updates to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants