Skip to content

fix: support initialization by appending IDs to containers #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

dakshpokar
Copy link
Collaborator

Pull Request

Description

This PR fixes the issue where only the first plot had the aria-label maidr instruction on how to activate.

Related Issues

xability/py-maidr#140

Checklist

  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code and ensured it follows the project's coding standards.
  • I have tested the changes locally following ManualTestingProcess.md, and all tests related to this pull request pass.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if applicable.
  • I have added appropriate unit tests, if applicable.

@jooyoungseo jooyoungseo merged commit da6b498 into main Feb 28, 2025
1 check passed
@jooyoungseo jooyoungseo deleted the fix/aria-label-maidr-instruction branch February 28, 2025 16:44
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
## [2.30.1](v2.30.0...v2.30.1) (2025-02-28)

### Bug Fixes

* support initialization by appending IDs to containers ([#638](#638)) ([da6b498](da6b498))
Copy link
Contributor

🎉 This PR is included in version 2.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants